ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [Patch] change org.apache.tools.ant.taskdefs.Concat to use static method FileUtils.readFully
Date Fri, 03 Dec 2004 14:57:55 GMT
On Wed, 01 Dec 2004, Jesse Glick <jesse.glick@sun.com> wrote:
> Stefan Bodewig wrote:
>> Initially we thought we'd provide subclasses for different OSes
>> like OpenVMSFileUtils or NetwareFileUtils and would use
>> newFileUtils as a factory method.

> But it seems that various methods already do OS-dependent checks;
> this should work equally well with static methods, right?

Yes.  You must have missed my

> We never did so, though.

The way the methods are implemented is not the way we envisioned when
we made FileUtils a factory.  Somehow the OS dependent code crept into
the methods as ifs instead of getting rolled into subclasses.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message