ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Conor MacNeill <co...@apache.org>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java
Date Wed, 22 Dec 2004 23:00:18 GMT
yes, there is an additional test to ensure the class D remains.

Conor


Martijn Kruithof wrote:
> Hi,
> 
> this test case would now also pass if no class has been found at all, is 
> that intentional?
> 
> Kind Regards, Martijn
> 
> conor@apache.org wrote:
> 
>> conor       2004/12/22 06:08:23
>>
>>  Modified:    src/testcases/org/apache/tools/ant/taskdefs/optional/depend
>>                        DependTest.java
>>  Log:
>>  JDM 1.5 compiler is much smarter than previous versions in the 
>> handling of
>>  class references which should improve the performance of <depend>
>>  
>>  The test has been changed to work with either, allowing eitehr one or 
>> two files
>>  PR:    32557
>>  
>>  Revision  Changes    Path
>>  1.16      +2 -2      
>> ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java 
>>
>>  
>>  Index: DependTest.java
>>  ===================================================================
>>  RCS file: 
>> /home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java,v

>>
>>  retrieving revision 1.15
>>  retrieving revision 1.16
>>  diff -u -w -u -r1.15 -r1.16
>>  --- DependTest.java    16 Dec 2004 14:01:39 -0000    1.15
>>  +++ DependTest.java    22 Dec 2004 14:08:23 -0000    1.16
>>  @@ -71,8 +71,8 @@
>>       public void testClosure() {
>>           executeTarget("testclosure");
>>           Hashtable files = getResultFiles();
>>  -        assertEquals("Depend did not leave correct number of files", 2,
>>  -            files.size());
>>  +        assertTrue("Depend did not leave correct number of files", 
>>  +            files.size() <= 2);
>>           assertTrue("Result did not contain D.class",
>>               files.containsKey("D.class"));
>>       }
>>  
>>  
>>  
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>>  
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message