ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kev Jackson <kevin.jack...@it.fts-vn.com>
Subject Re: [Patch] DirectoryScanner
Date Thu, 09 Dec 2004 03:02:02 GMT

>>     /**
>>-     * gets whether or not a DirectoryScanner
>>follows symbolic links
>>+     * Sets whether or not a DirectoryScanner
>>follows symbolic links
>>      *
>>-     * @return flag indicating whether symbolic
>>links should be followed
>>+     * @return whether or not symbolic links should
>>be followed
>>      *
>>      * @since ant 1.6
>>      */
>>    
>>
>[SNIP]
>
>Is that the doc for isFollowSymlinks() that you have
>changed to "Sets whether..."?
>  
>
Yes, sorry typo, but a very bad one at that since it is the complete 
opposite of the code.

I wonder if there is a javadoc tool that will check the semantic meaning 
of comments against code - similar to checkstyle but comparing method 
code vs doc comments.  That would catch these mistakes without hassling 
overworked commiters :)

Sorry again, I'll try to be more careful with anything else that I 
submit. /me suitably chastised.

Kev



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message