ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Jackson <kevin.jack...@it.fts-vn.com>
Subject [Patch] style of UpToDate
Date Thu, 02 Dec 2004 09:47:15 GMT
Just removed the C++ style private variables

Why set dir to null here?  Is there a problem with the size of the 
object and the GC not collecting it in time?  if not it doesn't seem to 
be relevant

protected boolean scanDir(File srcDir, String[] files) {
        SourceFileScanner sfs = new SourceFileScanner(this);
        FileNameMapper mapper = null;
        File dir = srcDir;
        if (mapperElement == null) {
            MergingMapper mm = new MergingMapper();
            mm.setTo(this.targetFile.getAbsolutePath());
            mapper = mm;
            dir = null;
        } else {
            mapper = mapperElement.getImplementation();
        }
        return sfs.restrict(files, srcDir, dir, mapper).length == 0;
    }

Kev

Mime
View raw message