Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 93617 invoked from network); 1 Dec 2004 05:17:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Dec 2004 05:17:36 -0000 Received: (qmail 17140 invoked by uid 500); 1 Dec 2004 05:17:32 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 17088 invoked by uid 500); 1 Dec 2004 05:17:32 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 17064 invoked by uid 99); 1 Dec 2004 05:17:32 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from main.gmane.org (HELO main.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 30 Nov 2004 21:17:30 -0800 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CZMrn-0002Lu-00 for ; Wed, 01 Dec 2004 06:17:27 +0100 Received: from 209-6-203-157.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.203.157]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Dec 2004 06:17:27 +0100 Received: from jesse.glick by 209-6-203-157.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Dec 2004 06:17:27 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: Re: [Patch] change org.apache.tools.ant.taskdefs.Concat to use static method FileUtils.readFully Date: Wed, 01 Dec 2004 00:17:22 -0500 Organization: Sun Microsystems Lines: 22 Message-ID: References: <4191AEB0.1020205@it.fts-vn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 209-6-203-157.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 X-Accept-Language: en-us, en In-Reply-To: Sender: news X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Stefan Bodewig wrote: > Initially we thought we'd provide subclasses for different OSes like > OpenVMSFileUtils or NetwareFileUtils and would use newFileUtils as a > factory method. We never did so, though. > > Some of the functionality would be the same among all OSes (like > closing streams or reading files completely) and could be static, > others like normalizing file names would be OS dependent and had to > be non-static. But it seems that various methods already do OS-dependent checks; this should work equally well with static methods, right? Since the OS does not change during the VM lifetime (I would hope!) there is no reason to keep any state in a FileUtils instance (you could use static variables if you needed to cache something), so there is no reason to have an instance at all. -J. -- Jesse Glick x22801 NetBeans, Open APIs --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org