Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 39199 invoked from network); 16 Nov 2004 02:48:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 16 Nov 2004 02:48:24 -0000 Received: (qmail 13615 invoked by uid 500); 16 Nov 2004 02:48:22 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 13572 invoked by uid 500); 16 Nov 2004 02:48:21 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 13558 invoked by uid 99); 16 Nov 2004 02:48:21 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [210.245.44.131] (HELO mail.fts-vn.com) (210.245.44.131) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 15 Nov 2004 18:48:18 -0800 Received: from firewall ([210.245.44.130] helo=[172.16.1.104]) by mail.fts-vn.com with esmtp (Exim 4.34) id 1CTtL1-0001pt-P1 for dev@ant.apache.org; Tue, 16 Nov 2004 09:44:59 +0700 Message-ID: <41996A45.6040000@it.fts-vn.com> Date: Tue, 16 Nov 2004 09:47:33 +0700 From: Kevin Jackson User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/metamata AbstractMetamataTask.java MParse.java References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Dominique Devienne wrote: >>From: Stefan Bodewig [mailto:bodewig@apache.org] >>All of the fixes I committed have either been for shadowed defintions >>or statics used as non-statics. There also is a warning about switch >>fall-throughs in JavaEnvUtils but they are wanted. >> >> > >Thanks for the summary. My own Java code prefixes member vars with an >underscore, so I don't see much local vars shadowing myself. --DD > > My compiler (eclipse 3, Jikes on Panther) complains alot about local variables hiding class variables. Although I wanted to rename them (just to be rid of 1000+ warning messages), I decided that perhaps there was a reason (ie naming convention). Still most of the problems could be fixed really easily - If you'd like I'll go through and use qualifiers (this.X) or rename them all and supply a patch - I'd like to do it to get rid of all the warnings I get, but I won't make changes unless people think it's worthwhile - "if it ain't broke, don't fix it" Kev --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org