Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 68494 invoked from network); 19 Nov 2004 06:45:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 19 Nov 2004 06:45:05 -0000 Received: (qmail 33206 invoked by uid 500); 19 Nov 2004 06:45:03 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 32994 invoked by uid 500); 19 Nov 2004 06:45:01 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 32980 invoked by uid 99); 19 Nov 2004 06:45:01 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 18 Nov 2004 22:44:58 -0800 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (8.12.11/8.12.11) with ESMTP id iAJ6ioFj012749 for ; Fri, 19 Nov 2004 07:44:50 +0100 Received: (from nobody@localhost) by ajax.apache.org (8.12.11/8.12.11/Submit) id iAJ6ioPY012747; Fri, 19 Nov 2004 07:44:50 +0100 Date: Fri, 19 Nov 2004 07:44:50 +0100 Message-Id: <200411190644.iAJ6ioPY012747@ajax.apache.org> From: bugzilla@apache.org To: dev@ant.apache.org Subject: DO NOT REPLY [Bug 27739] - sql insert statement fails on '--' strings X-Bugzilla-Reason: AssignedTo X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27739 ------- Additional Comments From kevin.jackson@it.fts-vn.com 2004-11-19 07:44 ------- I've just spent an unproductive 30 mins trying to duplicate this bug. I've only looked at the runStatements method as this seems to be the only one that actively looks for comments "--, // or REM" and tries to deal with them. My test SQL was a simple SELECT '--', '--' FROM USERS; --comment The method deals with these -- as it should do. I'm attaching a Junit test of the behaviour (excluding DB access). At first I was going to have two stubbed methods and then leave one whilst working on the other, but as the first exhibits the correct behaviour as far as I know, there didn't seem to be much point rewriting it. Notes: [1]I know that the code doesn't execute the SQL - my reasoning is that if the method doesn't break the SQL at the first --, then it's going to be fine when it passes it along to the DB - I'd process the statement if I was Oracle! [2]I know that it won't prove the absence of a bug, but I think it may point to a problem elsewhere, configuration, JDBC task etc? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org