ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Jackson <kevin.jack...@it.fts-vn.com>
Subject [Patch] change org.apache.tools.ant.taskdefs.Concat to use static method FileUtils.readFully
Date Wed, 10 Nov 2004 06:01:20 GMT
Was calling the method in a non-static manner.  Single letter change 
from fileUtils -> FileUtils.

Most of the newer code in FileUtils is non-static, but most of the older 
code is static, is this a historical oddity, or is there a reason for it?

Also the contructor is protected, but there's no need as the 
getFileUtils always returns a new object.  Why, wouldn't it be simpler 
to leave the constuctor as normal and use the class as a normal class, 
or to change the class to be a true Singleton, or to make it a 
completely static class?

Just some thoughts, there's probably a very good reason why it's the way 
it is, but I haven't figured it out yet.

Kev



Mime
View raw message