Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 73258 invoked from network); 8 Oct 2004 15:43:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 8 Oct 2004 15:43:14 -0000 Received: (qmail 47235 invoked by uid 500); 8 Oct 2004 15:43:11 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 47147 invoked by uid 500); 8 Oct 2004 15:43:11 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 47134 invoked by uid 99); 8 Oct 2004 15:43:10 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [134.132.72.99] (HELO junior.lgc.com) (134.132.72.99) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 08 Oct 2004 08:43:10 -0700 Received: from lgchvw02.lgc.com (lgchvw02.lgc.com [134.132.93.108]) by junior.lgc.com (8.11.7/8.11.3) with SMTP id i98Fh6i14196 for ; Fri, 8 Oct 2004 10:43:06 -0500 (CDT) Received: from 134.132.72.99 by lgchvw02.lgc.com (InterScan E-Mail VirusWall NT); Fri, 08 Oct 2004 10:43:03 -0500 Received: from HOUEXCH903.landmark.lgc.com (houexch903 [134.132.167.43]) by junior.lgc.com (8.11.7/8.11.3) with ESMTP id i98Fh0c14176 for ; Fri, 8 Oct 2004 10:43:00 -0500 (CDT) Received: from HOUEXCH902.landmark.lgc.com ([134.132.167.38]) by HOUEXCH903.landmark.lgc.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 8 Oct 2004 10:42:48 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: local properties Date: Fri, 8 Oct 2004 10:43:01 -0500 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: local properties Thread-Index: AcStTKe3bOGlcMi/Qg+nCsWQ2OCMygAABbBA From: "Dominique Devienne" To: "Ant Developers List" X-OriginalArrivalTime: 08 Oct 2004 15:42:48.0936 (UTC) FILETIME=[76BC5E80:01C4AD4D] X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N > From: Peter Reilly [mailto:peterreilly@apache.org] > Jose Alberto Fernandez wrote: >=20 > >I just posted something on bug 23942 about a different approach > >to this issue that I implemented on my machine at home. > > > >It is a very small addition to macro and it does not require > >any changes to the ANT machinery. I think everything we want > >to be able to do in macros can be done this way. > > > > > Yes I have seen it. > I do not like it, - the ${@{var}} syntax is a bit ikky ;-) > However, it does solve the macrodef use case so if people > go for it, I would have no objection.! I haven't looked at your impl Peter, but there are two things about Jose Alberto's proposal I wanted to note: 1) The generated unique name would need to at least use the 'let' name's as a prefix, otherwise the verbose/debug output of Ant will be difficult to use when troubleshooting. 2) All these uniquely named properties go on living after the macro has executed. That pollutes the namespace. I'd prefer a solution that (1) doesn't leak out any temporary property once the macro is done executing, and (2) that uses the simpler and macro-specific @{name} notation. If Peter's patch does this, then I'd prefer his. Thanks, --DD --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org