Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 13333 invoked from network); 28 Oct 2004 09:31:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 28 Oct 2004 09:31:29 -0000 Received: (qmail 74441 invoked by uid 500); 28 Oct 2004 09:31:25 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 74372 invoked by uid 500); 28 Oct 2004 09:31:24 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 74356 invoked by uid 99); 28 Oct 2004 09:31:24 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from [213.94.219.177] (HELO corvil.com) (213.94.219.177) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 28 Oct 2004 02:31:23 -0700 Received: from [172.18.1.171] (angel.local.corvil.com [172.18.1.171]) by corvil.com (8.12.9/8.12.5) with ESMTP id i9S9VGwS035613 for ; Thu, 28 Oct 2004 10:31:18 +0100 (IST) (envelope-from peterreilly@apache.org) Message-ID: <4180BCD3.5090205@apache.org> Date: Thu, 28 Oct 2004 10:33:07 +0100 From: Peter Reilly User-Agent: Mozilla Thunderbird 0.8 (X11/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/types CommandlineJava.java PropertySet.java References: <20041028091203.3806.qmail@minotaur.apache.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Stefan Bodewig wrote: >On 28 Oct 2004, wrote: > > > >> fix for previous fix - use getProperty() and not get() >> >> > >What if the keys/values are not Strings? > > In this case, the "properties" are from System.getProperties() and not from Project.getProperties().... so they are strings. The issue is that System.getProperties().get() was used rather that System.getProperties().getProperty() get() may bypass the default resolving logic in the jdk (looking at the code, this seems to be the case) Peter >There must be a very old bug lurking in Bugzilla that was resolved by >not assuming that the Ant properties table only contains Strings. > >I'm not sure whether the system properties table gets abused in a >similar way by anybody. If so, this is a backwards incompatible >change, I guess. > >Stefan > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org >For additional commands, e-mail: dev-help@ant.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org