Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 67955 invoked from network); 1 Sep 2004 10:42:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Sep 2004 10:42:01 -0000 Received: (qmail 61234 invoked by uid 500); 1 Sep 2004 10:41:07 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 61042 invoked by uid 500); 1 Sep 2004 10:41:04 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 60935 invoked by uid 99); 1 Sep 2004 10:41:01 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=HTML_60_70,HTML_MESSAGE,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [193.109.238.66] (HELO dnsinet.rzf-nrw.de) (193.109.238.66) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 01 Sep 2004 03:40:58 -0700 Received: from z011104.bk.fin.local (z011104.bk.fin.local [193.109.238.140]) by dnsinet.rzf-nrw.de (8.12.10/8.12.10) with ESMTP id i81AenvR031123 for ; Wed, 1 Sep 2004 12:40:49 +0200 Received: by z011104.bk.fin.local with Internet Mail Service (5.5.2657.72) id ; Wed, 1 Sep 2004 12:40:51 +0200 Message-ID: <879A5AD5DD0ED511891F0003473A9B560E23F55B@Z011004> From: Jan.Materne@rzf.fin-nrw.de To: dev@ant.apache.org Subject: AW: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.j ava Date: Wed, 1 Sep 2004 12:40:50 +0200 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2657.72) Content-Type: multipart/alternative; boundary="----_=_NextPart_001_01C49010.25DEEE60" X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N ------_=_NextPart_001_01C49010.25DEEE60 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable 1. Copy has also other protected variables 2. refactoring via getter is possible (but not as fast :) 3. I wanted to fix the gumpy-message as fast as possible (and you know=20 the refactoring tools of notepad ;-) Jan > -----Urspr=FCngliche Nachricht----- > Von: Antoine Levy-Lambert [mailto:antoine@gmx.de] > Gesendet am: Mittwoch, 1. September 2004 12:16 > An: Ant Developers List > Betreff: Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs > Copy.java >=20 > Hello Jan, > I thought we wanted to have fields always private. > This is what checkstyle checks. > Cheers, > Antoine >=20 > > jhm 2004/09/01 00:02:23 > >=20 > > Modified: src/main/org/apache/tools/ant/taskdefs Tag:=20 > ANT_16_BRANCH > > Copy.java > > Log: > > Let compile. > > =20 > > Revision Changes Path > > No revision > > No revision > > 1.66.2.6 +2 -2 =20 > > ant/src/main/org/apache/tools/ant/taskdefs/Copy.java > > =20 > > Index: Copy.java > > =20 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: > > /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Copy.java,v > > retrieving revision 1.66.2.5 > > retrieving revision 1.66.2.6 > > diff -u -r1.66.2.5 -r1.66.2.6 > > --- Copy.java 25 May 2004 12:12:56 -0000 1.66.2.5 > > +++ Copy.java 1 Sep 2004 07:02:23 -0000 1.66.2.6 > > @@ -66,7 +66,7 @@ > > protected boolean flatten =3D false; > > protected int verbosity =3D Project.MSG_VERBOSE; > > protected boolean includeEmpty =3D true; > > - private boolean failonerror =3D true; > > + protected boolean failonerror =3D true; > > =20 > > protected Hashtable fileCopyMap =3D new Hashtable(); > > protected Hashtable dirCopyMap =3D new Hashtable(); > > =20 > > =20 > > =20 > >=20 > >=20 > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > > For additional commands, e-mail: dev-help@ant.apache.org > >=20 >=20 >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org >=20 ------_=_NextPart_001_01C49010.25DEEE60--