ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31414] New: - cvstagdiff should handle module/package names with quotes
Date Fri, 24 Sep 2004 20:17:15 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31414>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31414

cvstagdiff should handle module/package names with quotes

           Summary: cvstagdiff should handle module/package names with
                    quotes
           Product: Ant
           Version: 1.7Alpha (nightly)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Core tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: dbarber@gmail.com


When generating the tag diff report, the xml generation does not handle quoted 
module names.  We have a situation where the module names have spaces in 
them.  To get ant to handle this condition, my module names need to be 
quoted.  When doing this, the xml output contains the package attribute with 
multiple quotes.  Here is the fix for the HEAD version of CvsTagDiff.java 
(sorry for the whitespace differences)

cvs server: Diffing .
Index: CvsTagDiff.java
===================================================================
RCS 
file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/cvslib/CvsTagD
iff.java,v
retrieving revision 1.23
diff -r1.23 CvsTagDiff.java
129a130
> 
221c222
< 
---
> 			
302c303
<                                 revSeparator);
---
> 									
	   revSeparator);
305,306c306,307
<                             revision,
<                             prevRevision);
---
> 									
			revision,
> 									
			prevRevision);
353c354
<                                      new OutputStreamWriter(output, "UTF-
8"));
---
> 									
			 new OutputStreamWriter(output, "UTF-8"));
368d368
<             writer.print("package=\"" + mypackage + "\" ");
369a370,379
> 			// handle cases where the package is quoted (spaces in 
the package name)
> 			if ( mypackage.indexOf("\"") < 0 )
> 			{
> 				writer.print("package=\"" + mypackage + "\" ");
> 			} // end of if ()
> 			else
> 			{
> 				writer.print("package=" + mypackage + " ");
				
> 			} // end of else
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message