ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31403] New: - cvsversion default task definition class has wrong package
Date Fri, 24 Sep 2004 12:01:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31403>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31403

cvsversion default task definition class has wrong package

           Summary: cvsversion default task definition class has wrong
                    package
           Product: Ant
           Version: 1.6.2
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Core tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: andy.wood@ditg.tv


defaults.properties lists cvsversion as:
cvsversion=org.apache.tools.ant.tasksdefs.cvslib.CvsVersion
this should read:
cvsversion=org.apache.tools.ant.taskdefs.cvslib.CvsVersion
(i.e. there shouldn't be two 's's in taskdefs)

Workaround is to add explicit:
<taskdef name="cvsversion" 
classname="org.apache.tools.ant.taskdefs.cvslib.CvsVersion"/>
to build.xml
____

Also, cvsversion.html documentation lists property attributes as:
cvsserverproperty
cvsclientproperty
When they're actually:
serverversionproperty
clientversionproperty
This is correctly documented in the javadoc.
____

Finally (and sorry to overload bug report) can the task detect CVSNT version
numbers which are displayed as:
Client: Concurrent Versions System (CVSNT) 2.0.4 (client/server)
By perhaps modifying line 127 of CvsVersion.java to read:
            } else if (currentToken.equals("(CVS)") || currentToken.equals
("(CVSNT)") ) {

Although it may be more useful to extract the content of the parentheses and
tack it on to the end of the property value if it's not plain (CVS).  i.e.
   Client: Concurrent Versions System (CVSNT) 2.0.4 (client/server)
   Server: Concurrent Versions System (CVS) 1.11.1p1 (client/server)
would return
   clientversionproperty=2.0.4 (CVSNT)
   serverversionproperty=1.11.1p1
respectively.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message