ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31215] - "Trying to override task definition" logged as MSG_WARN instead of MSG_VERBOSE
Date Tue, 14 Sep 2004 17:54:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31215>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31215

"Trying to override task definition" logged as MSG_WARN instead of MSG_VERBOSE





------- Additional Comments From peterreilly@apache.org  2004-09-14 17:54 -------
First thanks for the clear report!

The two myecho2 macros are different - they do have different behaviour
when <myecho2/> is used. As you point out, this is due to the different
setting of the defaulted attribute.

The similar/same issue came for attempting to deal with:
<project default="call">
   <taskdef name="x" classname="y" classpath="z"/>
   <target name="call">
      <antcall target="callee"/>
   </target>
   <target name="callee">
      <x/>
   </target>
</project>

This is a common use-case, and we do not want to get a
message that "x" has been redefined. The second definition
is not exactly the same as the first - it may have a different
classloader, hence the similar method and the VERBOSE message.

If someone did:

<project>
   <taskdef name="x" classname="y"/>
   <taskdef name="x" classname="anotherclass"/>
</project>

We want to tell the user that x has been redefined. {Although
there are bug reports about this been too noisey}.

The same idea carries over to macrodef (and the other *def)
functions.

The issue with AntTypeDefinition.similarDefinition not checking
to see if the classloaders are the same is a bug - thanks.


So the question is, should ant report the differences between
the two definitions of <myecho2> ?

I see a number of solutions:

1) treat differences in default values as "similar" - your patch
2) treat all redefinitions as VERBOSE
3) leave as is

As this is important from the point of view of intergration
with netbeans, I would be inclined to option 1) or option 2).
However, I would like other comments before committing the patch.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message