ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 30760] - sql task handle pl/sql with ';' in pl/sql code. (patch)
Date Mon, 23 Aug 2004 19:16:02 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=30760>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30760

sql task handle pl/sql with ';' in pl/sql code. (patch)





------- Additional Comments From ervandew@yahoo.com  2004-08-23 19:16 -------
Well, i think the only goal of the <sql> task needs to be how to delimit
statements.  The parsing of the statement is ultimatly done by the driver and
the database.  The <sql> task just needs to be smart enough to determine where
one statement ends and a new one begins.  Unfortunatly the task just fails to do
so in my example.

With that in mind the task only needs to be responsible for knowing what the
standard is on delimiting statements.  As far as i know that standard is ';'.
Allowing the user to override that is obviously a necessity and no surprise that
you guys included it.

Now, my issues is, does that ';' (or other delimiter) count as a delimiter when
it's in an unterminated string?  I don't believe any database would consider a
statement containing an unterminated string valid, which is why all the other
database independent tools (which are java based just like ant) that i've tried
will not delimit a statement on a line ending ';' when it's enclosed in an
unterminated string.  They will continue to parse the remainder of the statement
until that string is closed and then a ';' is encountered.

It's my opinion that the <sql> task should do the same.

Also, just to clarify, i'm doing all my tesing on Postgresql, not Oracle.  If
this was just an Oracle specific problem, then i would be behind you 100%. 
Oracle has earned it's reputation as the Microsoft of databases, and i wouldn't
expect you to add 1 to 101 different cases to handle quirks they tend to throw
at people.  Although, they do own a substantial market share, and supporting
their caveats is a necessity these days even in open source software.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message