Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Message-ID: <879A5AD5DD0ED511891F0003473A9B560E23F2EC@Z011004>
From: Jan.Materne@rzf.fin-nrw.de
To: dev@ant.apache.org
Subject: AW: Issues with <modified /> selector.
Date: Tue, 6 Jul 2004 17:49:11 +0200 
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C46370.C7DB46E0"

------_=_NextPart_001_01C46370.C7DB46E0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I am on integrating the suggestions. But there is one point I need =
help:
Robert gave a complete new source [1] as attachement to the RFE [2]. Do =
we
need
a CLA?

Jan


[1] =
http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=3D11932
[2] http://issues.apache.org/bugzilla/show_bug.cgi?id=3D29743


> -----Urspr=FCngliche Nachricht-----
> Von: Jan.Materne@rzf.fin-nrw.de [mailto:Jan.Materne@rzf.fin-nrw.de]
> Gesendet am: Mittwoch, 23. Juni 2004 13:18
> An: dev@ant.apache.org
> Betreff: AW: Issues with <modified /> selector.
>=20
> I=B4ll have a deeper look into that
> (but now I have to ensure that my new computer is able to run=20
> - the old was
> damaged :(
>=20
>=20
> Jan
>=20
>=20
> > -----Urspr=FCngliche Nachricht-----
> > Von: Robert Rice [mailto:robert@windermere.com]
> > Gesendet am: Dienstag, 22. Juni 2004 20:23
> > An: dev@ant.apache.org
> > Betreff: Issues with <modified /> selector.
> >=20
> > Recently, I submitted two bugs related to the modified selector.
> >=20
> > Bug 29742 addresses the issue that the Modified selector=20
> > doesn't allow=20
> > algorithm or comparator selection.  Only the default choices=20
> > of "digest"=20
> > and "equal" respectively are allowed. =20
> >=20
> > I have created a bug fix for the modified selector that=20
> > addresses this=20
> > issue.=20
> > In the bug fix, the algorithm and comparator initialization=20
> > logic has been
> > changed to allow choosing away from default.
> >=20
> > At the same time, I have created another algorithm type,=20
> > "checksum", that=20
> > makes
> > use of the java.util.zip.Checksum interface.  It is chosen by=20
> > setting the
> > alogrithm attribute to "checksum" ( <modified=20
> > algorithm=3D"checksum" /> ). =20
> >=20
> > This checksum allows the choice of CRC32 or Alder32, which utilize
> > java.util.zip.CRC32 and java.util.zip.Adler32 respectively. =20
> > This choice=20
> > is made
> > by setting the algorithm.algorithm parameter to "CRC" or=20
> > "ADLER", with the
> > default being "CRC" ( <modified algorithm=3D"checksum"><param
> > name=3D"algorithm.algorithm" value=3D"ADLER" /></modified> )
> >=20
> > How do I submit such changes for evaluation and possible inclusion?
> >=20
> > Bug 29743 addresses a bigger issue in that the modified=20
> > selector has poor=20
> > cachefile save performance.  The architecture of the selector=20
> > framework=20
> > dictates that the selector is notified of files, one at a=20
> > time, through=20
> > the isSelected method.  It is at this method call, that the cache=20
> > properties file is saved.  This properties file is saved=20
> every time a=20
> > file modification is found, possibly as many times as there=20
> > are files in=20
> > the fileset.  This leads to poor performance when process=20
> > large filesets=20
> > with multiple changes, in my case around 15000.
> >=20
> > I would like to delay the saving of the file until we are=20
> > finished with=20
> > the fileset or finished with the selector.  It looks to me,=20
> like this=20
> > requires the addition of one of more methods to the selector=20
> > framework,=20
> > likely to BaseSelector.=20
> >=20
> > In the case of the modified selector, we may be able to get=20
> away with=20
> > knowing we are finished with the selector through some method=20
> > call like=20
> > "tearDown".  At this point, the modified selector could save its=20
> > properites file.
> >=20
> > Another option is to add filesetListener type of behavior to=20
> > the BaseSelector.
> > This would notify a selector when a fileset selection has=20
> started and=20
> > ended. With this option, the modified selector could save its=20
> > properties=20
> > file at the end of fileset selection.
> >=20
> >=20
> >=20
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
> >=20
>=20

------_=_NextPart_001_01C46370.C7DB46E0--