ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: new Task subclass
Date Thu, 22 Jul 2004 15:42:47 GMT
--- Stefan Bodewig <bodewig@apache.org> wrote:
[SNIP]
> > But if the same principles apply, <target> would
> be restricted from
> > expression evaluation for the same reasons as it
> is restricted from
> > property evaluation, no?
> 
> Probably yes.  The only things where I see a
> technical reason are
> depends and name, I don't see a real technical
> reason to not allow
> expansion on if, unless or description.

Okay, now my mind is back in order--"depends" was the
crux of the aforementioned argument, and as Conor
reminded us the last time we talked about this, he
already added property evaluation to <target
if/unless> for Ant 1.4 .  Non-issue, then.

[SNIP]
> > Also, let me add this reminder to the discussion: 
> > IMHO we should be able to completely substitute
> Ant's
> > PropertyHelper, and further we should be able to
> do it
> > using Definitions and References, i.e. with
> current
> > infrastructure, and without writing Java code,
> 
> I'm not sure it should be done via References, but I
> agree that it
> should be easy to do - and possible to do from
> within the build file.
> The examples we have in the sandbox all combine a
> PropertyHelper with
> a task that installs it.  This works and would look
> like
> 
> <taskdef name="myph"
> classname="my.PropertyHelperInstallingTask"/>
> <myph/>

Doesn't that seem like extra work?  I feel it is
counter-intuitive to say "all you have to do is extend
PropertyHelper, OH YEAH and your custom class has to
also install itself or you can write an entirely
separate installer."  If Ant keeps track of the
current PropertyHelper (which it does) with a
reference, then it is The Way We Do Things Around Here
to assign a different object to that reference and
everything just WORKS.  That's what I think, anyway.

> 
> Stefan
> 
-Matt


		
__________________________________
Do you Yahoo!?
Yahoo! Mail is new and improved - Check it out!
http://promotions.yahoo.com/new_mail

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message