ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28599] - Access to a Location for a Target
Date Mon, 19 Jul 2004 18:04:32 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28599>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28599

Access to a Location for a Target

jglick@netbeans.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.2                       |1.7



------- Additional Comments From jglick@netbeans.org  2004-07-19 18:04 -------
Correction: while in Ant 1.6.2 Target does indeed have the getLocation() method,
it does not work - it is always UNKNOWN_LOCATION, I guess. The trunk version
works because the setLocation method is actually called:

Date: 2004/04/26 18:49:51
Author: mbenson
Branch: HEAD
Tag: (none) 
Log:
Add a Location member to oata.Target, with the appropriate settor & gettor.
PR:  28599

Members: 
	Target.java:1.51->1.52 
	helper/AntXMLContext.java:1.9->1.10 
	helper/ProjectHelper2.java:1.45->1.46 

But in ANT_162, the AntXMLContext and ProjectHelper2 patches did not make it;
only the Target patch was merged:

Date: 2004/06/11 17:38:56
Author: mbenson
Branch: ANT_16_BRANCH
Tag: (none) 
Log:
Merge Target.getIf/Unless() + Target Location from HEAD
PR: 28599, 29320

Members: 
	Target.java:1.46.2.6->1.46.2.7 

I suggest the remainder of the fix be merged to ANT_16_BRANCH to make it into
Ant 1.6.3, because the method in 1.6.2 is useless.

By the way, I detected this problem using unit tests for the NB Ant integration
(collecting Location's from target-specific BuildEvent's in a custom logger); it
would be a good idea for Ant itself to have such tests, probably. There are some
subtleties involved in setting the location for implicit or imported targets
which would be easy to mess up without noticing at first.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message