Return-Path: 
 <dev-return-57784-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 32905 invoked from network); 13 May 2004 13:06:06 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 13 May 2004 13:06:06 -0000
Received: (qmail 12071 invoked by uid 500); 13 May 2004 13:05:34 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 11787 invoked by uid 500); 13 May 2004 13:05:31 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 11620 invoked by uid 98); 13 May 2004 13:05:30 -0000
Received: from anonymous@nagoya.betaversion.org by hermes.apache.org by uid 82
 with qmail-scanner-1.20
 (clamuko: 0.70.  Clear:RC:0(192.18.33.10):.
 Processed in 0.231569 secs); 13 May 2004 13:05:30 -0000
X-Qmail-Scanner-Mail-From: anonymous@nagoya.betaversion.org via
 hermes.apache.org
X-Qmail-Scanner: 1.20 (Clear:RC:0(192.18.33.10):. Processed in 0.231569 secs)
Received: from unknown (HELO exchange.sun.com) (192.18.33.10)
  by hermes.apache.org with SMTP; 13 May 2004 13:05:28 -0000
Received: (qmail 914 invoked by uid 50); 13 May 2004 13:06:19 -0000
Date: 13 May 2004 13:06:19 -0000
Message-ID: <20040513130619.913.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: dev@ant.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 28941]  -
    [patch] javac && onCompile support
X-Spam-Rating: hermes.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28941>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28941

[patch] javac && onCompile support





------- Additional Comments From tquas@yahoo.com  2004-05-13 13:06 -------
Other code generators I'm using don't do such checks. XDoclet was just an
example. A badly chosen one, I admit.

You're probably right, and it would be more in Ant's spirit to use 'depends'
instead of <antcall>; however, I don't see how this would solve the problem.
Using 'depends' the only change in the script above would be in the "build" target:

    <target name="build" depends="compile,gen.hibernate.mappings,build.jar"/>

Still, the major issue here is that Ant must not execute
"gen.hibernate.mappings" or "build.jar" if nothing has been compiled in the
previous step. IMHO, a good way to communicate that is via properties and
<target if="x">.

Just for curiousity: why is 'depends' much faster? This particular build script
compiles 9 modules in about 30 secs. How much faster than <antcall> could
'depends' be? Are we talking milliseconds? Seconds?

Using <dependset> can obviously not be faster because it has to check timestamps
on files. And since it removes target files it doesn't look like a good match
anyways.

I'd be happy to use Ant's existing mechanisms, but I don't see a straightforward
solution using its current capabilities. Hence the patch.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org