Return-Path: 
 <dev-return-57592-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 64667 invoked from network); 4 May 2004 09:58:47 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 4 May 2004 09:58:47 -0000
Received: (qmail 62180 invoked by uid 500); 4 May 2004 09:58:20 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 62000 invoked by uid 500); 4 May 2004 09:58:18 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 61987 invoked from network); 4 May 2004 09:58:18 -0000
Received: from unknown (HELO exchange.sun.com) (192.18.33.10)
  by daedalus.apache.org with SMTP; 4 May 2004 09:58:18 -0000
Received: (qmail 10364 invoked by uid 50); 4 May 2004 09:59:24 -0000
Date: 4 May 2004 09:59:24 -0000
Message-ID: <20040504095924.10363.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: dev@ant.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 28745]  -
    SQL Task treatment of "--" is incorrect
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28745>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28745

SQL Task treatment of "--" is incorrect





------- Additional Comments From j_a_fernandez@yahoo.com  2004-05-04 09:59 -------
The problem with comments is more complex than people think.
SQLServer (at least older releases) does not allow new lines on the SQL 
statement passed by JDBC and it does not allow comments either.

So, for that DB you need to clean all this things up.
Oracle has a different set of behaviours. What was implemented was what was
considered safer for most of them.

I see that now people are asking for more DBspecific behaviour. Maybe we need 
to start thinking on a pluggable architecture for <sql/> that would allow
user access to the special features of a particular DB.

To start with, it could define the correct default values for the different 
settings that make the best way to send the SQL to the particular DB.

Does it make sense? The pluggins could autodetect based of the driver being 
used.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org