ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject Re: SSH tracking
Date Wed, 07 Apr 2004 10:12:44 GMT
On Tue, 6 Apr 2004, Rami Ojares <> wrote:

> Have a look at this patch Stefan. (It's patch from the whole
> directory) I added verbose attribute and rearranged things a little.

A few comments.

* I don't see you using SSHBase in AbstractSshMessage at all, so you
  don't need to add it as an attribute.  The subclasses only need to
  know whether verbose output has been requested, so they don't need
  a reference to sshbase either, just the flag.

* You are changing the public API of some classes.  This may be
  necessary, but we must not remove the old signatures completely.
  Delegate to the new one using reasonable defaults and @deprecate the
  old ones, but don't remove them.

* We've removed all @author tags in CVS HEAD, your patch shows that
  you're working copy is from the 1.6 branch.  You'd better use CVS
  HEAD for your patch, but the difference can be adapted to easily.

If you take the first two together, you'd get something like

    public ScpToMessage(Session session,
                        File aLocalFile,
                        String aRemotePath) {
        this(false, session, aLocalFile, aRemotePath);

    public ScpToMessage(boolean verbose,
                        Session session,
                        File aLocalFile,
                        String aRemotePath) {




To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message