ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Reilly <peter.rei...@corvil.com>
Subject Re: cvs commit: ant/src/etc/testcases/taskdefs fail.xml
Date Thu, 29 Apr 2004 10:38:17 GMT
I see a small problem here.
Exit was extending Task, and now is extending ConditionBase.
ConditionBase does not extend Task so this breaks
backward compatiblity.

It may be better to do this:

<exit>
   <condition>
      <equals arg1="a" arg2="${dir.name}"/>
   </condition>
</exit>

rather that:
<exit>
   <equals arg1="a" arg2="${dir.name}"/>
</exit>

(Dispite the fact that I normally argue against extra nesting).

Peter

mbenson@apache.org wrote:

>    * @since Ant 1.2
>    *
>    * @ant.task name="fail" category="control"
>    */
>  -public class Exit extends Task {
>  +public class Exit extends ConditionBase {
>       private String message;
>       private String ifCondition, unlessCondition;
>
>
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message