ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28565] - org.apache.tools.ant.taskdefs.Execute
Date Tue, 27 Apr 2004 17:48:00 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28565>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28565

org.apache.tools.ant.taskdefs.Execute





------- Additional Comments From gus_goose@canada.com  2004-04-27 17:47 -------
Hi again all (Matt).

I have just viewed the fix committed to CVS, and I am not sure it is the best
approach (sorry to be a PITA). I believe that the closes should happen only
AFTER the stop() method is called on the ExecuteStreamHandler, which means
moving them from the waitFor(), and putting tme in the execute(). My concern is
that the threads  reading from the streams we close may still be active until
the stop() is called, causing IOExceptioons if the read() on the stream when it
is closed. It would thus be better to close() after the handler is stopped,
where we have more certainty that any reading threads have terminated.

gus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message