ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28096] - jjtree outputdirectory now required
Date Mon, 05 Apr 2004 16:51:03 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28096>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28096

jjtree outputdirectory now required





------- Additional Comments From javadotant@shadowland.demon.nl  2004-04-05 16:51 -------
Are you referring to this dicussion ?

Stefan,

See javadoc for method validateOutputFile:
    * When running JJTree from an Ant taskdesk the -OUTPUT_DIRECTORY must
    * always be set. But when -OUTPUT_DIRECTORY is set, -OUTPUT_FILE is
    * handled as if relative of this -OUTPUT_DIRECTORY. Thus when the
    * -OUTPUT_FILE is absolute or contains a drive letter we have a problem.

Thus when the outputdirectory is supplied the outputfile is no longer treated as
an absolute path but relative to that outputdirectory, and therefore starting
the outputfile with an / or \ is kind of ignored.
At the moment I'm working on a patch that transforms the absolute outputfile to
an relative outputfile for the default outputdirectory (project basedirectory)
when the outputdirectory is not supplied.
Leaving a drive letter as the only problem. But the because when JavaCC is run
from the commandline with an outputdirectory and and outputfile (containing a
drive letter) this will result in a file of the form <outputdirectory>/<drive
letter>: which is empty. Thus always blocking a drive letter in the outputfile
is justified imho.

I will attach the patch in bugzilla today or tomorrow,

         Jene.

Stefan Bodewig wrote:

>
> ------------------------------------------------------------------------
>
> Subject:
> DO NOT REPLY [Bug 21526] - Enhancement JavaCC, JJTree and JJDoc [update]
> From:
> bugzilla@apache.org
> Date:
> 29 Jul 2003 14:48:05 -0000
> To:
> dev@ant.apache.org
>
>
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH
THE WEB INTERFACE AVAILABLE AT
> <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21526>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG
DATABASE.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21526
>
> Enhancement JavaCC, JJTree and JJDoc [update]
>
>
>
>
>
> ------- Additional Comments From bodewig@apache.org  2003-07-29 14:48 -------
> Some questions
>
> +        if ((outputDirectory == null)
> +            && (outputFile.startsWith("/") || outputFile.startsWith("\\")))
> +        {
> +            throw new BuildException("Absolute path in 'outputfile' not
> supported: " + outputFile);
> +        }
>
> _*only if outputdirectory has not been set?  I.e. absolute paths are supported
> if it has been set?
> *_
> +            throw new BuildException("Drive letter in 'outputfile' not
> supported: " + outputFile);
>
> Is this a general limitation of jjtree?
>
>  
>
>> Maybe this table could be attached to jjtree.html ?
>>   
>
>
> Of course it can, if you send a patch
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message