ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Parallel.java
Date Thu, 01 Apr 2004 13:06:46 GMT
peterreilly    2004/04/01 05:06:45

  Modified:    .        WHATSNEW
               src/main/org/apache/tools/ant/taskdefs Parallel.java
  Log:
  <parallel>: failonany was tested even if the task succeeded.
  PR: 28122
  Reported by: Oliver Dungey
  
  Revision  Changes    Path
  1.578     +2 -0      ant/WHATSNEW
  
  Index: WHATSNEW
  ===================================================================
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.577
  retrieving revision 1.578
  diff -u -r1.577 -r1.578
  --- WHATSNEW	31 Mar 2004 11:45:01 -0000	1.577
  +++ WHATSNEW	1 Apr 2004 13:06:45 -0000	1.578
  @@ -97,6 +97,8 @@
   
   * wrong compare used in ProjectComponent for logging. Bugzilla Report 28070.
   
  +* failOnAny attribute for <parallel> was broken. Bugzilla Report 28122.
  +
   Other changes:
   --------------
   
  
  
  
  1.29      +3 -3      ant/src/main/org/apache/tools/ant/taskdefs/Parallel.java
  
  Index: Parallel.java
  ===================================================================
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Parallel.java,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- Parallel.java	9 Mar 2004 16:48:06 -0000	1.28
  +++ Parallel.java	1 Apr 2004 13:06:45 -0000	1.29
  @@ -417,12 +417,12 @@
                   task.perform();
               } catch (Throwable t) {
                   exception = t;
  +                if (failOnAny) {
  +                    stillRunning = false;
  +                }
               } finally {
                   synchronized (semaphore) {
                       finished = true;
  -                    if (failOnAny) {
  -                        stillRunning = false;
  -                    }
                       semaphore.notifyAll();
                   }
               }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message