ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jose Alberto Fernandez" <jalbe...@cellectivity.com>
Subject RE: <depends/> and no-op output
Date Mon, 01 Mar 2004 18:43:57 GMT
> From: Matt Benson [mailto:gudnabrsam@yahoo.com] 
> 
> --- Rob Oxspring <roxspring@imapmail.org> wrote:
> > One of my (very few) pet hates with ant is that the
> > depends task
> > displays something when it performs a no-op.  This
> > 
> > I was wondering if there was any point in preparing
> > a patch to not
> > output/log if 0 files have been deleted.  The patch
> > / change would be 
> > laughably small but I'm not 100% that it'll sit well
> > with everyone as 
> > depends feels like its been around for a few
> > releases now and this would 
> > be a change to the output.  I could complicate the
> > patch by making it 
> > configurable (lognoop="no"??) if that makes people
> 
> 
> Since the current behavior does not really qualify as
> a bug, it is not safe to assume that a change to the
> default behavior of a task would not break someone's
> build.  

OK, why would a change in an output message would break
anyones build. We do change things when spellings are incorrect. 
I would suggest just logging this message as debug when changes = 0.


So supporting this behavior using a lognoop
> attribute (default true) via "public void
> setLognoop(boolean lognoop) {...}" would be A Good
> Thing.  If you want to prepare the patch and create an
> RFE in Bugzilla someone will probably commit it.

My problem with adding yet another attribute here
is that we are adding complexity for the users and for the code
without IMHO any real justification for it.

Maybe I am wrong, but I would like to see a meaningful example.

Jose Alberto

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message