Return-Path: 
 <dev-return-54463-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 31386 invoked from network); 16 Jan 2004 16:02:55 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 16 Jan 2004 16:02:55 -0000
Received: (qmail 21374 invoked by uid 500); 16 Jan 2004 16:02:48 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 21346 invoked by uid 500); 16 Jan 2004 16:02:48 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 21329 invoked from network); 16 Jan 2004 16:02:47 -0000
Received: from unknown (HELO corvil.com) (213.94.219.177)
  by daedalus.apache.org with SMTP; 16 Jan 2004 16:02:47 -0000
Received: from corvil.com (preilly.local.corvil.com [172.18.1.173])
	by corvil.com (8.12.9/8.12.5) with ESMTP id i0GG2mEu007166
	for <dev@ant.apache.org>; Fri, 16 Jan 2004 16:02:48 GMT
	(envelope-from peter.reilly@corvil.com)
Message-ID: <40080A93.5060804@corvil.com>
Date: Fri, 16 Jan 2004 16:00:19 +0000
From: Peter Reilly <peter.reilly@corvil.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: New Launcher and JPackage RPMs
References: <m3zncp8cip.fsf@bodewig.bost.de> <4006B228.6090702@corvil.com>
 <4006BB21.3000507@antbuild.com> <4006CEF3.70104@corvil.com>
 <4006D11D.6080206@antbuild.com> <4008000B.5060908@corvil.com>
 <400803EC.8020306@antbuild.com>
In-Reply-To: <400803EC.8020306@antbuild.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Antoine L�vy-Lambert wrote:

> Peter Reilly wrote:
>
>> Antoine L�vy-Lambert wrote:
>>
>>> I am +1 to get this into ant 1.6.1.
>>
>>
>>
>> (in relation to static map of jarfile->manifest class path in
>> AntClassLoader2).
>>
>> Ok I will commit that.
>>
>> Another optimization I tried was a quick hack to DefBase to have a 
>> static field containing the default classloader, so it
>> gets set once.  This did speed up the typedef the second and 
>> subsequent times and reduced the
>> time for the test to 1.6 second (from 3 and thus below the 1.5.4 
>> times (2 second) when using the crimson xml parser).
>
>
>
> Sounds useful.
>
>> However it is a complete hack, and does not deal with non-default 
>> classpaths  like:
>> <typedef classpath="${antlib.jar}" 
>> resource="net/sf/antcontrib/antcontrib.properties"/>
>>
> Do you mean : your change is bringing an optimization for taskdefs 
> which are done based on jars which have already been loaded by the 
> launcher, presumably because they are in $ANT_HOME/lib or in a -lib 
> directory  ?

No, the optimization is that if the <typedef/> does not define a 
classpath, a cached classloader is used. This
cached classloader gets set once (the first call).

Jose's more general caching solution souds more promising.

Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org