Return-Path: 
 <dev-return-54128-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 11356 invoked from network); 6 Jan 2004 18:54:25 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 6 Jan 2004 18:54:25 -0000
Received: (qmail 80338 invoked by uid 500); 6 Jan 2004 18:54:15 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 80187 invoked by uid 500); 6 Jan 2004 18:54:14 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 80165 invoked from network); 6 Jan 2004 18:54:13 -0000
Received: from unknown (HELO smtp.brightspark.com) (66.46.21.156)
  by daedalus.apache.org with SMTP; 6 Jan 2004 18:54:13 -0000
Received: from localhost (joshua [127.0.0.1])
	by smtp.brightspark.com (Postfix) with ESMTP id 7645470014
	for <dev@ant.apache.org>; Tue,  6 Jan 2004 14:04:24 -0500 (EST)
Received: from smtp.brightspark.com ([127.0.0.1])
 by localhost (joshua [127.0.0.1]) (amavisd-new, port 10029) with ESMTP
 id 08132-04 for <dev@ant.apache.org>; Tue,  6 Jan 2004 14:04:23 -0500 (EST)
Received: from mailer.corp.bspark.com (gateway.brightspark.com [66.46.41.93])
	by smtp.brightspark.com (Postfix) with ESMTP id 6D77E70008
	for <dev@ant.apache.org>; Tue,  6 Jan 2004 14:04:23 -0500 (EST)
Received: from exis.com ([10.5.200.133]) by mailer.corp.bspark.com with
 Microsoft SMTPSVC(5.0.2195.6713);
	 Tue, 6 Jan 2004 13:54:16 -0500
Message-ID: <3FFB0458.50600@exis.com>
Date: Tue, 06 Jan 2004 13:54:16 -0500
From: Colin Sampaleanu <colinml1@exis.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: Did 1.6 break old filter behaviour?
References: <3FFAEF05.4090606@exis.com> <3FFAF27D.6030001@corvil.com>
 <3FFAF7F7.9080004@exis.com> <3FFB00D0.6030404@corvil.com>
In-Reply-To: <3FFB00D0.6030404@corvil.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 06 Jan 2004 18:54:16.0962 (UTC)
 FILETIME=[7C1F0620:01C3D486]
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

That solution doesn't work too well, since I was relying on global 
filters for copying in several places, and don't want to redefine them 
each time. However, I was also already using
      <filterchain>
        <expandproperties/>
      </filterchain>
in the copy tasks, so until this is fixed I am doing something like this 
to define the filter/prop to replace:
    <!-- broken, use property instead -->
    <!--filter token="EMAIL_FROM" value="${email.from}" /-->
    <property name="EMAIL_FROM" value="${email.from}" />

and in my source file I have replaced all @EMAIL_FROM@ occurences to 
${EMAIL_FROM}

Regards,
Colin


Peter Reilly wrote:

> Until it gets fixed, you could use a filterchain with replacestring 
> instead:
>
>  <target name="chain">
>    <delete quiet="yes" file="filter.out"/>
>    <copy file="filter.inp" tofile="filter.out">
>      <filterchain>
>        <replacestring from="@EMAIL_FROM@" to="admin-dev@something.com"/>
>      </filterchain>
>    </copy>
>  </target>
>
> Peter
>
> Colin Sampaleanu wrote:
>
>> Bummer, this is pretty nasty...
>>
>> Peter Reilly wrote:
>>
>>> This looks like the same problem as
>>>
>>> http://issues.apache.org/bugzilla/show_bug.cgi?id=23154
>>> which we have not been able to reproduce.
>>>
>>> With an input file: filter.inp
>>> @EMAIL_FROM@ token
>>> @EMAIL_FROM@ token
>>>
>>> and a build file:
>>>
>>> <project>
>>>  <property name="email.from" value="admin-dev@something.com"/>
>>>  <filter token="EMAIL_FROM" value="${email.from}" />
>>>  <delete quiet="yes" file="filter.out"/>
>>>  <copy file="filter.inp" tofile="filter.out" filtering="yes"/>
>>> </project>
>>>
>>> the problem can be reproduced.
>>>
>>> Peter
>>>
>>> Colin Sampaleanu wrote:
>>>
>>>> I have a filter set as follows:
>>>>
>>>> <property name="email.from" value="admin-dev@something.com"/>
>>>> ...
>>>> <filter token="EMAIL_FROM" value="${email.from}" />
>>>>
>>>> this worked fine in ant 1.5, for replacing this filter value in a 
>>>> file with multiple @EMAIL_FROM@ tokens in it, via a copy task with 
>>>> filter="on"
>>>>
>>>> With ant 1.6, I now get this behaviour:
>>>>     [copy] Copying 1 file to 
>>>> D:\src\something\cvs\core\core-services\target\classes
>>>>     [copy] Replacing: @EMAIL_FROM@ -> admin-dev@something.com
>>>>     [copy] Inifinite loop in tokens. Currently known tokens : 
>>>> [EMAIL_FROM]
>>>>     [copy] Problem token : @EMAIL_FROM@ called from @EMAIL_FROM@
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     [copy] Replacing: @EMAIL_FROM@ -> EMAIL_FROM
>>>>     ... and so on
>>>>
>>>> Now obviously the @ sign in the email address is confusing the 
>>>> token processor, and it works fine if I replace it with another 
>>>> value, but this worked fine in ant 1.5!
>>>>
>>>> Can anybody confirm if this is a bug?
>>>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org