ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 25711] New: - Perforce task 'p4submit' should *not* set p4.needsresolve to 0 upon success
Date Mon, 22 Dec 2003 20:22:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25711>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25711

Perforce task 'p4submit' should *not* set p4.needsresolve to 0 upon success

           Summary: Perforce task 'p4submit' should *not* set
                    p4.needsresolve to 0 upon success
           Product: Ant
           Version: unspecified
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: eric@timebytes.com


When 'p4submit' finishes, it sets the property p4.needsresolve to 1 if the 
submit failed because some files need to be resolved before submission.  That's 
ok.  However, the docs state that p4submit sets the property to 0 if it 
succeeded.

That's incorrect behavior - firstly, because the target call flags 'if' 
and 'unless' check only if the property is set, not if it's set to 1.  This 
means it's harder to check if your perforce submit succeeded.  

The second problem is that ant properties are immutable - once they're set, 
they can't be changed.

That means I can't have my ant script do more than one submit at a time, 
because I won't be able to detect the results of the second submit.  That's not 
helpful.

I recognize there might be some backward-compatiblity issues - perhaps we 
should leave the existing property intact, and add a new property - 
p4.resolveneeded.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message