ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 25339] New: - javadoc task excludes packages with only package.html
Date Mon, 08 Dec 2003 20:53:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25339>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25339

javadoc task excludes packages with only package.html

           Summary: javadoc task excludes packages with only package.html
           Product: Ant
           Version: 1.5.3
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: derek@echologic.com


The javadoc task in 1.5.3 and 1.6beta3 both only pass pacakges to javadoc if
they contain .java files. It seems that they should include packages with only
package.html files as well. Does this seem reasonable?

Note that javadoc only includes these package.htmls if somewhere in the packages
below them at least one java file exists.

Here's a patch...

Index: main/org/apache/tools/ant/taskdefs/Javadoc.java
===================================================================
RCS file:
/apps/cvs/repos/ga_repos/Dovetail/bin/ant-1.5.3/src/main/org/apache/tools/ant/taskdefs/Javadoc.java,v
retrieving revision 1.1.1.1
diff -u -b -w -r1.1.1.1 Javadoc.java
--- main/org/apache/tools/ant/taskdefs/Javadoc.java	6 Jun 2003 22:07:28 -0000
1.1.1.1
+++ main/org/apache/tools/ant/taskdefs/Javadoc.java	8 Dec 2003 20:41:19 -0000
@@ -1948,7 +1948,7 @@
                 File pd = new File(baseDir, dirs[i]);
                 String[] files = pd.list(new FilenameFilter () {
                         public boolean accept(File dir1, String name) {
-                            if (name.endsWith(".java")) {
+                            if (name.endsWith(".java") ||
name.equals("package.html")) {
                                 return true;
                             }
                             return false;        // ignore dirs

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message