Return-Path: 
 <dev-return-52561-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 97480 invoked from network); 3 Nov 2003 14:08:25 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 3 Nov 2003 14:08:25 -0000
Received: (qmail 49313 invoked by uid 500); 3 Nov 2003 14:08:19 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 49267 invoked by uid 500); 3 Nov 2003 14:08:19 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 49250 invoked from network); 3 Nov 2003 14:08:18 -0000
Received: from unknown (HELO bodewig.bost.de) (62.96.16.111)
  by daedalus.apache.org with SMTP; 3 Nov 2003 14:08:18 -0000
Received: (from bodewig@localhost)
	by bodewig.bost.de (8.11.6/8.11.6) id hA3E8Iw03883;
	Mon, 3 Nov 2003 15:08:18 +0100
X-Authentication-Warning: bodewig.bost.de: bodewig set sender to
 bodewig@apache.org using -f
To: dev@ant.apache.org
Subject: Re: <macrodef> attributes as properties or as textual substitutions
 [was <local>]
References: <NCEPINDOKGPFICGMMGLNMEMCCFAA.antoine@antbuild.com>
From: Stefan Bodewig <bodewig@apache.org>
Date: 03 Nov 2003 15:08:18 +0100
In-Reply-To: <NCEPINDOKGPFICGMMGLNMEMCCFAA.antoine@antbuild.com>
Message-ID: <m33cd5h7e5.fsf@bodewig.bost.de>
Lines: 32
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Portable Code)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

On Fri, 31 Oct 2003, Antoine Levy-Lambert <antoine@antbuild.com>
wrote:

> What are the advantages of leaving macrodef with attributes
> implemented as textual substitutions ?

attributes don't hide properties.

If we implement attributes as properties, we have to decide whether
they are allowed to override existing (user-)properties of the same
name as well.  I don't think it would be problematic, as long as we
state the rules clear enough.

If they are only textual substitutions, they get confusing when we use
the property expansion syntax.

> Otherwise, of course, if we leave macrodef as it is with just a new
> notation for the attributes, then we can release 1.6 sooner.

I'd rather get this "right" as in community supported and unlikely to
break bc in Ant 1.7 now.

> If we choose a notation $() for macro attributes (for instance), can
> we implement macrodef with <local/> in 1.7 ?

You mean we make them textual replacements now and set (local)
properties in 1.7?  This would imply that attributes that didn't hide
properties in 1.6 would do so now.  And should we decide that
attributes must not override existing properties, this suddenly would
have to apply to $() instead of ${} as well.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org