Return-Path: 
 <dev-return-53259-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 31710 invoked from network); 27 Nov 2003 14:21:15 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 27 Nov 2003 14:21:15 -0000
Received: (qmail 38855 invoked by uid 500); 27 Nov 2003 14:21:09 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 38814 invoked by uid 500); 27 Nov 2003 14:21:08 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 38765 invoked from network); 27 Nov 2003 14:21:07 -0000
Received: from unknown (HELO corvil.com) (213.94.219.177)
  by daedalus.apache.org with SMTP; 27 Nov 2003 14:21:07 -0000
Received: from [172.18.1.173] (preilly.local.corvil.com [172.18.1.173])
	by corvil.com (8.12.9/8.12.5) with ESMTP id hAREL3d8036659
	for <dev@ant.apache.org>; Thu, 27 Nov 2003 14:21:07 GMT
	(envelope-from peter.reilly@corvil.com)
Subject: RE: Macrodef attributes and Local revisited again
From: Peter reilly <peter.reilly@corvil.com>
To: Ant Developers List <dev@ant.apache.org>
In-Reply-To: <D466FBEAA19E7E408BE3FAAC6EEB567605042307@utah.ignitemedia.com>
References: <D466FBEAA19E7E408BE3FAAC6EEB567605042307@utah.ignitemedia.com>
Content-Type: text/plain; charset=
Message-Id: <1069942798.6860.122.camel@preilly.local.corvil.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Thu, 27 Nov 2003 14:19:58 +0000
Content-Transfer-Encoding: 8bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

On Thu, 2003-11-27 at 13:50, Steve Cohen wrote:
> Peter - 
> >>but if macrodef properties are to be implemented as textual substitution
> >>and not as local properties, the two issues can be separated.
> 
> Did you mean to say "but if macrodef ATTRIBUTES are to be implemented as textual substitution and not as local properties ..."

Yes. I meant macrodef attributes... (I keep getting that
wrong).

Peter

> 
> Or are you talking about properties defined within the execution of a "call" to a macrodef?
> 
> -----Original Message-----
> From:	Peter reilly [mailto:peter.reilly@corvil.com]
> Sent:	Thu 11/27/2003 7:08 AM
> To:	dev@ant.apache.org
> Cc:	
> Subject:	Macrodef attributes and Local revisited again
> Yesterday I said that macrodef attributes should be implemented as
> properties and not as textual substitution.
> 
> On overnight reflection, I have changed by mind.
> 
> MacroDef has been using textual substitution in the ant beta
> builds without much problems (*.. well not quite see below).
> The only issue is the notation used is the same as for properties.
> 
> The proposed new notation is @{x} where x is the attribute.
> 
> I have implemented the new notation and added the following:
> 
>  * the escape sequence @@{x} is used to allow @{x} to be
>    placed in the text without substitution of x. - this
>    corresponds to the $${x} escape sequence for properties.
>  * the macro replacement is now done on the default values for
>    the attributes - this allows Jan's use case to work:
> 
>   <target name="jan">
>     <macrodef name="dep">
>       <attribute name="root"/>
>       <attribute name="file" default="@{root}.dep"/>
>       <sequential>
>         <script language="javascript"> <![CDATA[
>             // attribute expansion from macrodef (script can´t reach the
>             //   values)
>             root     = "@{root}";
>             file     = "@{file}";
>             importClass(java.lang.System);
>             System.out.println(
>                "root is " + root + " and file is " + file);
>                                          ]]>
>         </script>
>       </sequential>
>     </macrodef>
>     
>     <dep root="foo"/>
>   </target>
> 
> This prints out
> jan:
>    [script] root is foo and file is foo.dep
> 
> The order of the attributes is important - 
>     <macrodef name="dep">
>       <attribute name="file" default="@{root}.dep"/>
>       <attribute name="root"/>
> will set file to @{root}.dep.
> 
> 
> A problem encountered in using macrodef for any not trivial macros
> is the need to isolate the use of properties.
> For this I have proposed using the local property patch, but if
> macrodef properties are to be implemented as textual substitution
> and not as local properties, the two issues can be separated.
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org