Return-Path: 
 <dev-return-52398-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 12141 invoked from network); 26 Oct 2003 22:54:33 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 26 Oct 2003 22:54:33 -0000
Received: (qmail 88490 invoked by uid 500); 26 Oct 2003 22:54:18 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 88327 invoked by uid 500); 26 Oct 2003 22:54:18 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 88314 invoked from network); 26 Oct 2003 22:54:17 -0000
Received: from unknown (HELO ignitemedia.com) (64.157.167.108)
  by daedalus.apache.org with SMTP; 26 Oct 2003 22:54:17 -0000
X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0
Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C39C14.460D53EB"
Subject: Tale from the front: macrodef nesting
Date: Sun, 26 Oct 2003 16:55:38 -0600
Message-ID: <D466FBEAA19E7E408BE3FAAC6EEB5676050422A5@utah.ignitemedia.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Tale from the front: macrodef nesting
thread-index: AcOcFEYBH+VnQzB+TGeD7sfOjElUOg==
From: "Steve Cohen" <SCohen@sportvision.com>
To: <dev@ant.apache.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

------_=_NextPart_001_01C39C14.460D53EB
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

I am now trying to experiment with some of the new features of ant 1.6.  =
Here's a real-world example of the difficulties of trying to replace =
antcalls with macrodefs.

Given the following definitions, notice that I am trying to nest a call =
to the
macrodef make.precompiled.web.xml inside a call to the macrodef =
make.se.war.

This is failing because I am trying to use the ATTRIBUTE war.webxml =
inside the ELEMENT precompile which contains a call to the nested =
macrodef make.precompiled.web.xml.

I could easily fix this by substituting the actual value of the =
war.webxml attribute for the ${war.webxml} token.  But then I lose the =
advantage of defining this in a single place.

Or I can create properties in the macrodef and pass them around, but =
that feels wrong too. =20

Maybe there should be some mechanism for allowing inner macrodefs for =
inheriting attributes from an outer macrodef.  Maybe elements should be =
able to be defined with nested attributes.  Or something.

But this experience with trying to use this feature leads me to the =
feeling that using the same notation for macrodef attributes and ant =
properties is not a good thing.  It will definitely cause confusion.  At =
a minimum more documentation of this is required.


    <macrodef name=3D"make.precompiled.web.xml">
        <attribute name=3D"src.web.xml"/>
        <attribute name=3D"dest.web.xml"/>
        <sequential>           =20
            <ant antfile=3D"${basedir}/se/build-precomp.xml"
                 target=3D"create.precompiled.web.xml">
                <property name=3D"src.web.xml" =
value=3D"${src.web.xml}"/>
                <property name=3D"dest.web.xml" =
value=3D"${dest.web.xml}"/>
            </ant>
        </sequential>
    </macrodef>

    <macrodef name=3D"make.se.war">           =20
        <attribute name=3D"work.dir"/>
        <attribute name=3D"war.webxml"/>
        <attribute name=3D"war.basedir"/>
        <attribute name=3D"war.destfile"/>

        <element name=3D"precompile" optional=3D"true"/>
        <element name=3D"assemble" optional=3D"false"/>
        <element name=3D"additional" optional=3D"true"/>
                                       =20
        <sequential>
            <delete dir=3D"${work.dir}"/>    =20
            <mkdir dir=3D"${work.dir}/temp"/>=20
            <mkdir dir=3D"${work.dir}/war"/>=20
           =20
            <precompile/>
            <assemble/>
            <replace file=3D"${war.webxml}"=20
                     token=3D"#build#"               =
value=3D"${project.version}.${project.maintenance.build}.${project.fix.bu=
ild}"/>
            <war destfile=3D"${war.destfile}"
                 webxml=3D"${war.webxml}"
                 basedir=3D"${war.basedir}">
                <additional/>
            </war>
        </sequential>
    </macrodef>                        =20


       <target name=3D"make.admin.war"
               depends=3D"make.precompilation"
           <make.se.war=20
               work.dir=3D"${dir.admin.ear}"
               =
war.webxml=3D"${dir.build.precomp.webxml}/${admin.web.xml}"
               war.basedir=3D"${dir.admin.ear}/temp"
               war.destfile=3D"${dir.admin.ear}/war/${admin.war}">
               <precompile>
                   <make.precompiled.web.xml
                       =
src.web.xml=3D"${dir.src.web.xmls}/${admin.web.xml}"
                       dest.web.xml=3D"${war.webxml}"
                   />
               </precompile>
               <assemble>
                   <copy todir=3D"${war.basedir}">
                       <fileset dir=3D"${dir.build.war.precomp}"/>
                   </copy>
               </assemble>
           </make.se.war>
       </target>



------_=_NextPart_001_01C39C14.460D53EB--