ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: Vote: <local> for 1.6
Date Wed, 29 Oct 2003 12:06:46 GMT
On Wednesday 29 October 2003 10:42, Stefan Bodewig wrote:
> On Fri, 24 Oct 2003, peter reilly <peter.reilly@corvil.com> wrote:
> > On Friday 24 October 2003 12:36, Stefan Bodewig wrote:
> >> On Thu, 23 Oct 2003, peter reilly <peter.reilly@corvil.com> wrote:
> >> >    - should the uris of introspection discovered nested elements
> >> >    be the same as the containing task
> >
> > The example I gave before was this:
> >
> > <ant:project
> >     xmlns:ant="ant:core" xmlns:ac="antlib:net.sf.antcontrib">
I have just made the change from "ant:core" to antlib
> >     <ac:switch value="${foo}">
> >       <ant:case value="bar">
> >         <echo message="The value of property foo is bar" />
>
> is not defined IMHO, as we don't have a default namespace at all.

I persume that you mean the "echo" element.
As xmlns="..." has not been defined, it is up to the xml processor to
pick the uri associated with the null ns prefix. In ant's case it is
(now) "antlib:org.apache.tools.ant" so the above is (I think) correct.

>
> It would be Ant's core URI if that was the URI of the default
> namespace in the current scope and AntContrib's if it was theirs.
>
> >    <ac:if>
> >       <equals arg1="a" arg2="${prop}"/>
> >       <then>
> >          blab ...
> >        </then>
> >        <else>
> >          blab..
> >        </else>
> >    </ac:if>
>
> Assuming Ant's core URI was associated to the default namespace, you'd
> have to use ac:then and ac:else.

This is not the current ant 1.6 behaviour. All elements belong to
the core URI, except typedef'ed elements and whatever the user
wants to pass to DynamicConfigurable#

To change this would require (tricky) modifications to UnknownElement.cpp
and IntrospectionHelper.cpp.

>
> >> > * antlib support
> >> >    - should <typedef resource="x"/> look for all instances of x
> >> >    or just the first one.  + I think it should.
> >>
> >> you think it should what? 8-)
> >
> > I think that it should look for all instances of x ;-)
>
> I agree that it should do so for the XML style - but I'm not sure
> about property files as <typedef resource> is there since 1.4 for them
> and has always only loaded one file.

To be consistent for resource handling, I think that we should take the
hit for backward compatible. This should not be too bad here as multiple
resources of the same name for typedefed properties should not be
common and would for the most part be currently an error.

However, getting all instances for xml definitions and only the
first for property definitions would be backward compatible.

>
> > There is one small problem with this. If the default namescape is
> > changed from ant:core to antlib:org.apache.tools.ant, and people
> > make antlibs with the antlib.xml in the correct place, this could
> > cause auto declaration of third party tasks/types into the default
> > namespace.
>
> Didn't we want to allow this anyway?  I mean allow people to add tasks
> to the core namespace as traditional <taskdef> would do so as well.

Ok

Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message