ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: replacement of properties in addText(String)
Date Fri, 24 Oct 2003 15:35:04 GMT
On Friday 24 October 2003 14:56, Dominique Devienne wrote:
> > From: peter reilly [mailto:peter.reilly@corvil.com]
> > Sent: Friday, October 24, 2003 7:59 AM
> > To: dev@ant.apache.org
> > Subject: replacement of properties in addText(String)
> >
> > In
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=11585
> > there is a discussion about whether ant core should
> > do property replacement or whether a new introspection
> > method could be added to do this.
> >
> > If a new introspection method is added (this is quite easy
> > to do), what should it be called?
> >
> > I was thinking of addExpandedText(), but there could
> > be tasks out there with <exandedtext/> elements.
> >
> > Peter
>
> Why not simply addText(String message, boolean replaceProperties)?
>
> Since it's a two-args method, it can no longer conflict with an
> introspection point.
>
> Also, can someone explain me why Ant merges all the text segments of a
> node, when this node contains child elements? SAX doesn't, so why does Ant
> merge them? You thus loose the relative ordering between the child elements
> and the text notes... I'm sure someone will argue against mixed content,
> but adding String to a StringBuffer upon each call to addText(String) is no
> big deal at all IMHO, and the current behavior prevents useful uses of the
> lost ordering. Thanks, --DD

Why ?, I do not know. But the design of RuntimeConfigurable assumes that
all the text is merged before the user tasks see the text.

I do not think that this behaviour can be changed easily. Possibly
a new introspection method and a modification of the internal structure
of RuntimeConfigurable.

Peter

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message