Return-Path: 
 <dev-return-50664-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 65686 invoked from network); 17 Sep 2003 18:16:19 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 17 Sep 2003 18:16:19 -0000
Received: (qmail 70714 invoked by uid 500); 17 Sep 2003 18:16:04 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 70671 invoked by uid 500); 17 Sep 2003 18:16:03 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 70656 invoked from network); 17 Sep 2003 18:16:03 -0000
Received: from unknown (HELO relay.t-online-com.de) (62.156.147.74)
  by daedalus.apache.org with SMTP; 17 Sep 2003 18:16:03 -0000
Received: from D2CFT80J (internet-cafe-221.sapinternetcafe.de [155.56.24.221])
	by relay.t-online-com.de (SMTPSVC(1.0.0.2)) with ESMTP id C328914CAA3
	for <dev@ant.apache.org>; Wed, 17 Sep 2003 20:10:42 +0200 (CEST)
From: =?iso-8859-1?Q?Antoine_L=E9vy-Lambert?= <antoine@antbuild.com>
To: "Ant Developers List" <dev@ant.apache.org>
Subject: AW: Should <import> cause an error when used inside a <target>?
Date: Wed, 17 Sep 2003 20:15:20 +0200
Message-ID: <NCEPINDOKGPFICGMMGLNKECCCDAA.antoine@antbuild.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0)
In-Reply-To: <200309171521.02123.peter.reilly@corvil.com>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
Importance: Normal
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Sounds good,
Antoine

-----Urspr�ngliche Nachricht-----
Von: peter reilly [mailto:peter.reilly@corvil.com]
Gesendet: Mittwoch, 17. September 2003 16:21
An: Ant Developers List
Betreff: Re: Should <import> cause an error when used inside a <target>?


On Wednesday 17 September 2003 13:24, Stefan Bodewig wrote:
> On Wed, 17 Sep 2003, peter reilly <peter.reilly@corvil.com> wrote:
> > I think that the use-case is valid.
>
> Hmm, maybe - given the timing of Antoine's release plan - we should
> limit <import> to top-level right now and revisit nesteing import into
> targets later?

The original implementation was a bit hachy (modifing the vector
of tasks in target while reading it). I have made a new
implementation that makes a new target for top level tasks
of imported files and executes them in the same way as normal
top level tasks.

This implementation does handle your use-case (I think) and
sequential.
<parallel> may be a problem - need to think about protecting
access to the antcontext object in PH2.

Peter
>
> > One should also think about an <import> inside a sequential.
>
> Aaargh.  <import> inside <parallel> will be even more fun.
>
> Stefan
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org