Return-Path: 
 <dev-return-50895-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 46339 invoked from network); 23 Sep 2003 10:10:31 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 23 Sep 2003 10:10:31 -0000
Received: (qmail 81836 invoked by uid 500); 23 Sep 2003 10:10:03 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 81629 invoked by uid 500); 23 Sep 2003 10:10:01 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 81607 invoked from network); 23 Sep 2003 10:10:00 -0000
Received: from unknown (HELO dnsinet.rzf-nrw.de) (193.109.238.66)
  by daedalus.apache.org with SMTP; 23 Sep 2003 10:10:00 -0000
Received: from z011104.bk.fin.local (z011104.bk.fin.local [193.109.238.140])
	by dnsinet.rzf-nrw.de (8.12.10/8.12.10) with ESMTP id h8NAAB5O031166
	for <dev@ant.apache.org>; Tue, 23 Sep 2003 12:10:11 +0200
Received: by z011104.bk.fin.local with Internet Mail Service (5.5.2653.19)
	id <TJAV8BPV>; Tue, 23 Sep 2003 12:10:12 +0200
Message-ID: <879A5AD5DD0ED511891F0003473A9B5608FF7015@Z011004>
From: Jan.Materne@rzf.fin-nrw.de
To: dev@ant.apache.org
Subject: RE: concat teardown failing
Date: Tue, 23 Sep 2003 12:10:03 +0200
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C381BA.DB34B2F0"
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

------_=_NextPart_001_01C381BA.DB34B2F0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I have tried with closing them, but it doesn=B4t work.
But send me your code please. Maybe you have done some different :-)


Jan

> -----Original Message-----
> From: peter reilly [mailto:peter.reilly@corvil.com]
> Sent: Tuesday, September 23, 2003 12:04 PM
> To: Ant Developers List
> Subject: Re: concat teardown failing
>=20
>=20
> I think the problem is in o.a.t.a.filters.ConcatFilter
>=20
> The code opens the prepend and append files but
> does not close them.
>=20
> I have code that closes the files and passes the
> tests on linux, but do not have windows to
> test on.
>=20
> Peter
> On Tuesday 23 September 2003 10:17, Jan.Materne@rzf.fin-nrw.de wrote:
> > I need help ...
> >
> >
> > I have inserted some debug statements in=20
> FileUtils.copyFile() (line up
> > 531). And the result:
> >   FileUtils:538 - start
> >   FileUtils: 542
> >   FileUtils: 559 filterSetsAvailable=3Dfalse
> >   FileUtils:623
> >
> >=20
> sourceFile=3DC:\seu\cvs-downloads\ant\ant\src\etc\testcases\filt
> ers\input\con
> >c atfilter.test
> >
> >=20
> destFile=3DC:\seu\cvs-downloads\ant\ant\src\etc\testcases\filter
> s\result\conc
> >a t.filterReaderPrepend.test
> >   FileUtils:667
> >   FileUtils:669: close OUT=3Djava.io.BufferedWriter@14ae2c1
> >   FileUtils:671: close IN=3Djava.io.BufferedReader@16d2702
> >   FileUtils:705 - ende
> >   execute Target: cleanup
> >   Unable to delete file
> >=20
> C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\result\
> concat.filter
> >R eaderPrepend.test
> >
> >
> > The concat.filterReaderPrepend.test can=B4t be deleted but=20
> it=B4s closed in
> > line 669.
> >
> > Any ideas?
> >
> >
> > Jan
> >
> > > -----Original Message-----
> > > From: Jan.Materne@rzf.fin-nrw.de=20
> [mailto:Jan.Materne@rzf.fin-nrw.de]
> > > Sent: Tuesday, September 23, 2003 9:05 AM
> > > To: dev@ant.apache.org
> > > Subject: RE: concat teardown failing
> > >
> > >
> > > And I thought that=B4s only on my machine ... (that=B4s why I put =
that
> > > into a try-catch block in the tearDown() - the _real_=20
> test shouldn=B4t
> > > fail only because the cleanup fails ...)
> > >
> > > "task not closing things" - I will take a look into that.
> > > While programming I use java.io.FileReader without a close (I
> > > have tried
> > > that - without success). And the other filters doesn=B4t close
> > > the Reader
> > > either.
> > >
> > > More hints are welcome :-)
> > >
> > >
> > >
> > > Jan
> > >
> > > > -----Original Message-----
> > > > From: Steve Loughran [mailto:steve_l@iseran.com]
> > > > Sent: Tuesday, September 23, 2003 8:23 AM
> > > > To: Ant Developers List
> > > > Subject: concat teardown failing
> > > >
> > > >
> > > >
> > > > the cleanup script in concat.xml is failing. Looks to me like
> > > > the files
> > > > are still open when the delete task takes action. Could set
> > > > failonerror
> > > > flags to ignore it, but it may be a symptom of the task not
> > > > closing things.
> > > >
> > > > platform: winxp, java1.4.2
> > > >
> > > >      [junit] ------------- Standard Error -----------------
> > > >      [junit]
> > > >=20
> C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > > Unable to delete file
> > > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\co
> > > > ncat.filterReaderPrepend.test
> > > >      [junit] 	at
> > > > org.apache.tools.ant.taskdefs.Delete.removeDir(Delete.java:612)
> > > >      [junit] 	at
> > > > org.apache.tools.ant.taskdefs.Delete.execute(Delete.java:530)
> > > >      [junit] 	at
> > > >=20
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:303)
> > > >      [junit] 	at
> > >
> > > org.apache.tools.ant.Task.perform(Task.java:401)
> > >
> > > >      [junit] 	at
> > >
> > > org.apache.tools.ant.Target.execute(Target.java:338)
> > >
> > > >      [junit] 	at
> > > > org.apache.tools.ant.Target.performTasks(Target.java:365)
> > > >      [junit] 	at
> > > > org.apache.tools.ant.Project.executeTarget(Project.java:1237)
> > > >      [junit] 	at
> > > > org.apache.tools.ant.BuildFileTest.executeTarget(BuildFileTest
> > > > .java:273)
> > > >      [junit] 	at
> > > > org.apache.tools.ant.filters.ConcatFilterTest.tearDown(ConcatF
> > > > ilterTest.java:126)
> > > >
> > > > ...
> > > >
> > > >      [junit]
> > > >=20
> C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > > Unable to delete file
> > >
> > >=20
> =
C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\append.txt
> > >
> > > >      [junit]
> > > >=20
> C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > > Unable to delete file
> > > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\co
> > > > ncat.concatfilter.test
> > > >
> > > > ...
> > >
> > >=20
> ---------------------------------------------------------------------
> > >
> > > > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > > > For additional commands, e-mail: dev-help@ant.apache.org
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>=20

------_=_NextPart_001_01C381BA.DB34B2F0--