Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Date: 17 Sep 2003 09:23:29 -0000
Message-ID: <20030917092329.1019.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: dev@ant.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 23090]  -
    AbstractFileSet copy-constructor makes shallow copy

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23090>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23090

AbstractFileSet copy-constructor makes shallow copy

bodewig@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From bodewig@apache.org  2003-09-17 09:23 -------
I couldn't find a good reason for a shallow clone either, and in fact all our
tests passed after I changed it, we'll see what Gump says.

It turned out to be slightly more work as PatternSets are mutable and I had
to make them Clonable (good idea anyway) and explicitly clone the PatternSets
that make up the additionalPatterns Vector as the instances wouldn't have been
independent otherwise.  Same would go for selectors, but I couldn't easily
decide which selectors should be clonable (and which not, if any), so I stopped
with the pattern sets.

This means that if anybody modifies a selector already present in the original,
the original is going to be modified as well - which I've documented for now.

Fixed in nightly build 2003-09-18.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org