ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan.Mate...@rzf.fin-nrw.de
Subject RE: concat teardown failing
Date Tue, 23 Sep 2003 13:25:56 GMT
Thats the advantage of automated unit tests :-)

Ok, I refactor the test suite a little bit.

Because we have a 1.6 version and a head version on cvs. How should
I commit the changes?


Jan

> -----Original Message-----
> From: Stefan Bodewig [mailto:bodewig@apache.org]
> Sent: Tuesday, September 23, 2003 3:24 PM
> To: dev@ant.apache.org
> Subject: Re: concat teardown failing
> 
> 
> On Tue, 23 Sep 2003, Jan Materne <Jan.Materne@rzf.fin-nrw.de> wrote:
> 
> > I have modified the FileUtils.readFully(Reader rdr, int bufferSize)
> > so that it closes the reader and all works.
> 
> I think that would be the wrong place.  It may be my old C thinking
> coming from explicit memory managment, but I think that the code that
> aquires a resource should be responsible of releasing it as well.
> 
> > Ups - some other tests failed because of the closed reader. So I
> > close the reader in the ConcatFilterTest.
> 
> You see 8-)
> 
> Stefan
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
> 

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message