ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: concat teardown failing
Date Tue, 23 Sep 2003 10:04:01 GMT
I think the problem is in o.a.t.a.filters.ConcatFilter

The code opens the prepend and append files but
does not close them.

I have code that closes the files and passes the
tests on linux, but do not have windows to
test on.

Peter
On Tuesday 23 September 2003 10:17, Jan.Materne@rzf.fin-nrw.de wrote:
> I need help ...
>
>
> I have inserted some debug statements in FileUtils.copyFile() (line up
> 531). And the result:
>   FileUtils:538 - start
>   FileUtils: 542
>   FileUtils: 559 filterSetsAvailable=false
>   FileUtils:623
>
> sourceFile=C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\input\con
>c atfilter.test
>
> destFile=C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\result\conc
>a t.filterReaderPrepend.test
>   FileUtils:667
>   FileUtils:669: close OUT=java.io.BufferedWriter@14ae2c1
>   FileUtils:671: close IN=java.io.BufferedReader@16d2702
>   FileUtils:705 - ende
>   execute Target: cleanup
>   Unable to delete file
> C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\result\concat.filter
>R eaderPrepend.test
>
>
> The concat.filterReaderPrepend.test can´t be deleted but it´s closed in
> line 669.
>
> Any ideas?
>
>
> Jan
>
> > -----Original Message-----
> > From: Jan.Materne@rzf.fin-nrw.de [mailto:Jan.Materne@rzf.fin-nrw.de]
> > Sent: Tuesday, September 23, 2003 9:05 AM
> > To: dev@ant.apache.org
> > Subject: RE: concat teardown failing
> >
> >
> > And I thought that´s only on my machine ... (that´s why I put that
> > into a try-catch block in the tearDown() - the _real_ test shouldn´t
> > fail only because the cleanup fails ...)
> >
> > "task not closing things" - I will take a look into that.
> > While programming I use java.io.FileReader without a close (I
> > have tried
> > that - without success). And the other filters doesn´t close
> > the Reader
> > either.
> >
> > More hints are welcome :-)
> >
> >
> >
> > Jan
> >
> > > -----Original Message-----
> > > From: Steve Loughran [mailto:steve_l@iseran.com]
> > > Sent: Tuesday, September 23, 2003 8:23 AM
> > > To: Ant Developers List
> > > Subject: concat teardown failing
> > >
> > >
> > >
> > > the cleanup script in concat.xml is failing. Looks to me like
> > > the files
> > > are still open when the delete task takes action. Could set
> > > failonerror
> > > flags to ignore it, but it may be a symptom of the task not
> > > closing things.
> > >
> > > platform: winxp, java1.4.2
> > >
> > >      [junit] ------------- Standard Error -----------------
> > >      [junit]
> > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > Unable to delete file
> > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\co
> > > ncat.filterReaderPrepend.test
> > >      [junit] 	at
> > > org.apache.tools.ant.taskdefs.Delete.removeDir(Delete.java:612)
> > >      [junit] 	at
> > > org.apache.tools.ant.taskdefs.Delete.execute(Delete.java:530)
> > >      [junit] 	at
> > > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:303)
> > >      [junit] 	at
> >
> > org.apache.tools.ant.Task.perform(Task.java:401)
> >
> > >      [junit] 	at
> >
> > org.apache.tools.ant.Target.execute(Target.java:338)
> >
> > >      [junit] 	at
> > > org.apache.tools.ant.Target.performTasks(Target.java:365)
> > >      [junit] 	at
> > > org.apache.tools.ant.Project.executeTarget(Project.java:1237)
> > >      [junit] 	at
> > > org.apache.tools.ant.BuildFileTest.executeTarget(BuildFileTest
> > > .java:273)
> > >      [junit] 	at
> > > org.apache.tools.ant.filters.ConcatFilterTest.tearDown(ConcatF
> > > ilterTest.java:126)
> > >
> > > ...
> > >
> > >      [junit]
> > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > Unable to delete file
> >
> > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\append.txt
> >
> > >      [junit]
> > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\concat.xml:13:
> > > Unable to delete file
> > > C:\Java\Apache\jakarta-ant\src\etc\testcases\filters\result\co
> > > ncat.concatfilter.test
> > >
> > > ...
> >
> > ---------------------------------------------------------------------
> >
> > > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > > For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message