ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 23286] - [PATCH] suppression of useless import in testcase and some enhancements
Date Mon, 22 Sep 2003 08:21:19 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286

[PATCH] suppression of useless import in testcase and some enhancements





------- Additional Comments From emmanuel.feller@free.fr  2003-09-22 08:21 -------
I agree on public promotion but i did it only on classes which had their others 
fiels public (by accessor).

For the protected promotion i disagree because it is not a real problem : 
methods are visible by package and subclasses.
So if it is a problem for a field, it is a problem in conception which should 
not use really private field into a inner class (IMHO).

I may redo a patch with the suppression of useless import or useless variable. 
There is not debate on this point (IMHO).

And i may redo another for field visibility issues. So it will be more easy to 
check on every classes if it is a good solution or if we should refactor the 
source code.

waiting your comments,
Emmanuel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message