ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: GUMP failure caused by ANT (Re: [GUMP] Build Failure - Axis)
Date Wed, 10 Sep 2003 15:05:02 GMT
On Wednesday 10 September 2003 15:40, Stefan Bodewig wrote:
> On Wed, 10 Sep 2003, peter reilly <peter.reilly@corvil.com> wrote:
> > I did not really understand the original code,
>
> I think setProject has initially been package private so recreating
> the Property tasks from the new project has been the only option then.

Ah, that makes sense.

>
> > The code is a bit strange, it would have been simpler (and saver) to
> > create a new Ant object each time.
>
> That's what I suggested (if my mails get moderated through to
> axis-dev, that is).
>
> > I have made a change to Ant.java (attached) which will weed out
> > duplicate property elements. This should allow the Axis code to
> > work.
>
> It will probably also break backwards compatibility.
>
> <project default="2">
>   <target name="foo">
>     <echo>foo=${foo}</echo>
>   </target>
>
>   <target name="2">
>     <ant antfile="${ant.file}">
>       <property name="foo" value="bar"/>
>       <property name="foo" value="baz"/>
>     </ant>
>   </target>
> </project>
>
> echos foo=bar in 1.5.x, not foo=baz.

Yep, I have just released that (after I
committed the change).

Should I roll back the change?

Peter
>
> As I've written in one of my earlier mails, using the last value may
> be the more reasonable choice as
>
> ant foo -Dfoo=bar -Dfoo=baz
>
> would result in foo=baz.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message