ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22088] - Patch for MailMessage.java
Date Mon, 01 Sep 2003 19:41:41 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22088>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22088

Patch for MailMessage.java





------- Additional Comments From antoine@apache.org  2003-09-01 19:41 -------
OK, you may attach a new patch to this bug report, or maybe better create a new
bug report.
Concerning 7bit, 8bit or MIME, I have 3 questions/remarks :

1) what is the practical utility of letting the user choose here ?

2)if we need to offer the choice (between 7bit, 8bit or MIME) to the user, then
we need to patch also EMailTask and Mailer.
Currently, there is a encoding attribute in the EMailTask, whose possible values
are plain, uu, mime or auto. The real meaning of the attribute is
"implementation" because basically it is a choice between ant's own
implementation of sending email (PlainMailer and MailMessage classes)and 
JavaMail wrapped by the MimeMailer class.

3)would a name of "contenttype" for the new attribute with values 7bits, 8bits
or MIME be OK ?
this attribute needs to exist in EMailTask and to be pushed from EMailTask to
the Mailer abstract class, then to be read in the PlainMailer class and finally
used in the MailMessage class.

Does this contenttype attribute make sense for the JavaMail implementation of
the EMailTask (class MimeMailer) ? If not, this should be said in the docs and a
warning should be issued in EMailTask#execute

Cheers,

Antoine

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message