Return-Path: 
 <dev-return-49429-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 83310 invoked by uid 500); 12 Aug 2003 12:08:33 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 83214 invoked from network); 12 Aug 2003 12:08:31 -0000
Received: from gate.corvil.net (HELO corvil.com) (213.94.219.177)
  by daedalus.apache.org with SMTP; 12 Aug 2003 12:08:31 -0000
Received: from preilly.local.corvil.com (preilly.local.corvil.com
 [172.18.1.173])
	by corvil.com (8.12.9/8.12.5) with ESMTP id h7CC8U13046859
	for <dev@ant.apache.org>; Tue, 12 Aug 2003 13:08:31 +0100 (IST)
	(envelope-from peter.reilly@corvil.com)
From: peter reilly <peter.reilly@corvil.com>
Organization: corvil
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: [Patch] namespace and antlib
Date: Tue, 12 Aug 2003 13:15:24 +0100
User-Agent: KMail/1.5
References: <D44A54C298394F4E967EC8538B1E00F10248C5DA@lgchexch002.lgc.com>
 <200308011709.31477.peter.reilly@corvil.com> <m3adaf3y5m.fsf@bodewig.bost.de>
In-Reply-To: <m3adaf3y5m.fsf@bodewig.bost.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200308121315.24154.peter.reilly@corvil.com>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Tuesday 12 August 2003 12:36, Stefan Bodewig wrote:
> On Fri, 1 Aug 2003, peter reilly <peter.reilly@corvil.com> wrote:
> >   <typedef resource="net/sf/antcontrib/antlib.xml"
> >            uri="antlib:net.sf.antcontrib"
> >            classpath="/tmp/ant-contrib.jar"/>
>
> wouldn't the resource attribute be redundant in that case?

Not in this case. The automatic lookup of uri="antlib:net.sf.antcontrib" to
net/sf/antcontrib/antlib.xml resource currently is done once when the
ns prefix is encountered the first time - it does not take place at
the <typedef/> task.

>
> > 3) reserved uri's
>
> +1 on reserving the ant* protocol.

I have changed this to ant:*, as I found when testing
that the current code reserves antcontrib: and antelope: ....

>
> > 5) antlibs in the classpath
>
> I'm leaning towards a repository of antlibs, say ANT_HOME/antlibs with
> classloader isolation between different antlibs and discovery on
> demand here.  I.e. don't force the antlib to live on Ant's core
> classloader - and avoid scanning of the repository unless an antlib:*
> URI has been used.

This makes sense, but would involve some messing with classloaders and
scanning of the jar files in ANT_HOME/antlibs. Each time I look at
classloaders, my head melts down....

>
> > 6) adding new definitions to a uri
>
> What about overriding a definition?  Print a warning and succeed like
> <taskdef> would do now?
Yes, there is no difference.
>
> +1 on the proposal in general.

Excellent.
Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org