ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Wannheden" <knut.wannhe...@paranor.ch>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs MacroDef.java MacroInstance.java PreSetDef.java defaults.properties
Date Fri, 15 Aug 2003 11:15:26 GMT
What's the line:

    if (uri.startsWith("ant:") && !uri.startsWith("antlib:")) {

in MacroDef#setURI(String) about?  It can surely be written better :-)

But the code looks like it will be the same for many tasks, so maybe an
abstract AntlibTask and AntlibTaskContainer would be nice to have.  What do
you think?

--
knut




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message