ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22088] - Patch for MailMessage.java
Date Thu, 21 Aug 2003 16:26:36 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22088>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22088

Patch for MailMessage.java

antoine@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.6



------- Additional Comments From antoine@apache.org  2003-08-21 16:26 -------
Patches submitted with some modifications :
1) removed everything having to do with charset (alias encoding) from the patch
2 reasons for this : 
- org.apache.tools.ant.taskdefs.email.Message.java already handles charset 
properly when creating a PrintWriter
- technically the solution in the patch could not be compiled under JDK 1.2
I also saw that the PlainMailer needed to set the charset in the Content-Type 
header, this was really the only change to do to support charsets properly in 
ant's plain mail.
2) taken the opportunity to make MailMessage.java pass checkstyle
3) submitted most of the testcase - I removed from it what had to do with 
testing different charsets.
Most important : it is now possible to send readable plain mail messages with 
ant in foreign character sets.

Many thanks for the patches, especially for the testcase.


Cheers,
Antoine

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message