ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs MacroDef.java MacroInstance.java PreSetDef.java defaults.properties
Date Fri, 15 Aug 2003 14:13:30 GMT
On Friday 15 August 2003 12:15, Knut Wannheden wrote:
> What's the line:
>
>     if (uri.startsWith("ant:") && !uri.startsWith("antlib:")) {
>
> in MacroDef#setURI(String) about?  It can surely be written better :-)
opps..
>
> But the code looks like it will be the same for many tasks, so maybe an
> abstract AntlibTask and AntlibTaskContainer would be nice to have.  What do
> you think?
Yes,
the only problem is that I now have
AntlibInterface
   ^
   | implements
   |
   DefBase  (does classpath handling and uri)
   |
   | extends
   | 
   Definer  (this should be typedef, is definer for BC)
   |
   | extends
   |
   Typedef
   |
   | extends
   |
   Taskdef  (sets two attributes)
    
Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message