Return-Path: Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 93391 invoked by uid 500); 29 Jul 2003 09:34:09 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 93378 invoked from network); 29 Jul 2003 09:34:08 -0000 Received: from bodewig.bost.de (62.96.16.111) by daedalus.apache.org with SMTP; 29 Jul 2003 09:34:08 -0000 Received: (from bodewig@localhost) by bodewig.bost.de (8.11.6/8.11.6) id h6T9YLl16897; Tue, 29 Jul 2003 11:34:21 +0200 X-Authentication-Warning: bodewig.bost.de: bodewig set sender to bodewig@apache.org using -f To: dev@ant.apache.org Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/types Resource.java ZipScanner.java References: <20030729091008.71281.qmail@icarus.apache.org> From: Stefan Bodewig Date: 29 Jul 2003 11:34:21 +0200 In-Reply-To: <20030729091008.71281.qmail@icarus.apache.org> Message-ID: Lines: 27 User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Portable Code) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On 29 Jul 2003, wrote: > Some tasks rely on the DFS ordering getIncludedXYZ used to provide I'm not sure whether we want to provide this as the sort order has never been documented. The recent changes in DirectoryScanner could lead to a situation in which A/C will be returned before A/B, I don't think this is a big issue but patched it for completeness. The change to ZipScanner in turn is necessary as getIncludedDirectories could return A/B before returning A itself - this could cause trouble within Zip where the code assumes that the parents of a given directory have been added before the directory itself[1]. The change to Resource is merely cosmetic. Stefan Footnotes: [1] Not strictly true, the code will ensure that the parents have been added before, but may do the wrong thing WRT to Unix permissions once my next patch to Zip is committed. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org