Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Message-ID: <879A5AD5DD0ED511891F0003473A9B5608FF6C92@Z011004>
From: Jan.Materne@rzf.fin-nrw.de
To: dev@ant.apache.org
Subject: RE: cvs commit: ant/src/main/org/apache/tools/zip ZipOutputStream
	.java
Date: Tue, 22 Jul 2003 13:48:32 +0200
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C35047.2D3C1C00"

------_=_NextPart_001_01C35047.2D3C1C00
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

> >        /**
> >   +     * Deflater object for output=20
> >   +     *
> >   +     * @since 1.14
> >   +     */
> >   +    protected Deflater def =3D new
Deflater(Deflater.DEFAULT_COMPRESSION, true);
> >   +   =20
> >   +    /**
> >   +     * Deflater buffer
> >   +     *
> >   +     * @since 1.14
> >   +     */
> >   +    protected byte[] buf =3D new byte[512];
>=20
> protected and not private (as checkstyle will certainly find out 8-).
>=20
> The reason for this is that ZipOutputStream used to extend
> java.util.zip.DeflaterOutputStream which has those two protected
> members.  It now extends FilterOutputStream directly and this will
> provide a certain level of API compatibility.  I'm not sure that we
> really want to go that far.
>=20
> Stefan


I think that as a short java comment inside that code would be good. =
Then
future
committers remind that and don=B4t modify the accessibility.


Jan

------_=_NextPart_001_01C35047.2D3C1C00--