Return-Path: 
 <dev-return-48811-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 82859 invoked by uid 500); 30 Jul 2003 08:01:12 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 82839 invoked from network); 30 Jul 2003 08:01:11 -0000
Received: from exchange.sun.com (192.18.33.10)
  by daedalus.apache.org with SMTP; 30 Jul 2003 08:01:11 -0000
Received: (qmail 4842 invoked by uid 50); 30 Jul 2003 08:03:58 -0000
Date: 30 Jul 2003 08:03:58 -0000
Message-ID: <20030730080358.4841.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: dev@ant.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 18154]  -
    SimpleP4OutputHandler can throw exceptions that should be build exceptions
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18154>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18154

SimpleP4OutputHandler can throw exceptions that should be build exceptions





------- Additional Comments From antoine@apache.org  2003-07-30 08:03 -------
My proposition : change SimpleP4OutputHandler so that it is only going to throw 
build exceptions if the attribute failonerror of P4Base is set to true (the 
default). If failonerror is set to false, then the error message would be logged 
with Project.MSG_ERR as you suggested in your patch.

On top of that, one could add a new Perforce property called p4.failonerror 
which, if set, would contain the default value for failonerror.

So :
<property name="p4.failonerror" value="false"/> at the top of a build file
would disable exception throwing from SimpleP4OutputHandler.

Alternatively or parallel, you would be able to add the "failonerror" attribute 
for problem tasks.

Is this OK ?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org